Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move AccumulatorUpdateData to hermes client #2292

Closed

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Move AccumulatorUpdateData.ts and its tests from price-service-sdk to hermes-client to better organize the code and prepare for future changes.

Changes:

  • Move AccumulatorUpdateData.ts to apps/hermes/client/js/src/
  • Move AccumulatorUpdateData.test.ts to apps/hermes/client/js/src/tests/
  • Update imports in price-service-sdk to use @pythnetwork/hermes-client
  • Add necessary exports in hermes-client's index.ts

Note: This PR requires the following package dependency updates that will be added once approved:

  1. Add @pythnetwork/hermes-client as dependency in price-service-sdk
  2. Add bn.js and @types/bn.js in hermes-client

Link to Devin run: https://app.devin.ai/sessions/b7079c5c563c4668ad29a29d534bd056

Move AccumulatorUpdateData.ts and its tests from price-service-sdk to hermes-client
to better organize the code and prepare for future changes. This change:

- Moves AccumulatorUpdateData.ts to apps/hermes/client/js/src/
- Moves AccumulatorUpdateData.test.ts to apps/hermes/client/js/src/__tests__/
- Updates imports in price-service-sdk to use @pythnetwork/hermes-client
- Adds necessary exports in hermes-client's index.ts

Note: This PR requires package dependency updates that will be added once approved.

Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 4:19pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 4:19pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 4:19pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 4:19pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 4:19pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 4:19pm

devin-ai-integration bot and others added 2 commits January 23, 2025 16:01
…p copy in hermes

Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants